Add wrapper around node and connection #9

New issue

Closed

opened 2026-05-20 19:23:02 +00:00 by linarphy · 2 comments

linarphy commented

2026-05-20 19:23:02 +00:00

Owner

The goal is to avoid user of this library to use pattern like

online_state = node.state.online
if not isinstance(online_state, NodeIsOnline):
    raise TypeError
connections = online_state.outgoing_connections

This already exists with Node.connect which is a wrapper around Node.state.online.connect and raise an error if the node is not online.

These pattern happens right now when we want:

fetch connections of a given node
? I think that’s it

There is two solutions I think of:

add Node.get_neighbors_by_node_type(type_), Node.get_neighbors_by_node_data(filter_), etc…
add utils.get_neighbors_by_node_type(node, type_), etc…
add a query builder, to answer request with better function than these. This could be a SPARQL engine !

I prefer option 1 over option 2. Ultimately, I feel like option 3 is the future proof best answer. We shouldn’t need to have that many function to fetch for neighbors. Having a query engine that can express exactly what we want is better.

The goal is to avoid user of this library to use pattern like ```py online_state = node.state.online if not isinstance(online_state, NodeIsOnline): raise TypeError connections = online_state.outgoing_connections ``` This already exists with `Node.connect` which is a wrapper around `Node.state.online.connect` and raise an error if the node is not online. These pattern happens right now when we want: - fetch connections of a given node - ? I think that’s it There is two solutions I think of: 1. add `Node.get_neighbors_by_node_type(type_)`, `Node.get_neighbors_by_node_data(filter_)`, etc… 2. add `utils.get_neighbors_by_node_type(node, type_)`, etc… 3. add a query builder, to answer request with better function than these. This could be a SPARQL engine ! I prefer option 1 over option 2. Ultimately, I feel like option 3 is the future proof best answer. We shouldn’t need to have that many function to fetch for neighbors. Having a query engine that can express exactly what we want is better.